CLOK BBS

I reported this a while back, but since it effects a lot of players I figured I'd post this in more detail here. If your horse attacks in a combat round and misses (which is almost certain if you're fighting tough things and have the war riding abliity) you receive no skillgains in anything regardless of whether you hit something. Example:

You attack a X with your X and Y!
X (+) (M:X vs D:X) 7 hack + 1 alchemical damage to the left arm!
Y (=) (M:X vs D:X) 24 crush + 3 alchemical damage + to the head!
X (+) (M:X vs D:X) 8 slash + 5 alchemical damage -- to the right leg!
(energy -4)
A sturdy auburn stallion attacks a X with its hoof kick!
hoof kick (-----) (M:761 vs D:1450) Dodged!

In this round you receive no weapon skillgain, shield skillgain, melee skillgain, or riding skillgain, even though you hit with all your attacks. In a round where my horse didn't attack, I'd receive all of these skillgains. Maybe as a quick fix you could disable hoof kicks or something? I know there's a lot of stuff to work on, but this makes it effectively impossible to train riding (or anything while else on horseback) now that I have the war riding skill.

I'll admit, I've been dragging my feet on this. Mostly because riding combat is just unfun to work with in the code. It has been an ongoing bug since pretty much, forever, though, so I finally went ahead and narrowed it down and fixed it.

Before:
No gains besides ride if your mount attacks the same turn as you.

(Changing combat position to Engage)
You attack a massive golem with your iron-headed javelin!
javelin (=) (M:414 vs D:400)(0.0082 ride)
43 pierce + 6 alchemical damage (right foot)
Eloss is: 5
(energy -5)
A bulky black warhorse attacks a massive golem with its hoof kick!
hoof kick (+++) (M:450 vs D:291) Dodged!

After:
Everything's normal!

(Changing combat position to Engage)
You attack a massive golem with your iron-headed javelin!
javelin (=) (M:414 vs D:400)(0.0082 ride)
50 pierce + 7 alchemical damage (back)
Eloss is: 5
(energy -5)
A bulky black warhorse attacks a massive golem with its hoof kick!
hoof kick (++) (M:450 vs D:332) 56 crush damage (left hand)
(0.03 gen_combat)
(+2.25 guildpoints for dwaedn guild.)
(+2.25 guildpoints for mercenary guild.)
(+2.25 guildpoints for brofist guild.)
(+2.25 guildpoints for aranas guild.)
(+2.25 guildpoints for assassin guild.)
(+2.25 guildpoints for templar guild.)
(0.03 polearm)

Thank you!

Very nice.

Do those of the Wyrvardn join in on the love of mounted combat skill gains? :)